Add a dynamic reconfigure value to not set arbitrarily brightness, co… #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrast, hue and saturation
|
@furushchev what do you think? I'd like a second opinion if you have a minute to spare. |
furushchev
requested changes
Apr 11, 2021
| gen.add("width", int_t, LEVEL.RUNNING, "Target width", 0, 0, 10000) | ||
| gen.add("height", int_t, LEVEL.RUNNING, "Target height", 0, 0, 10000) | ||
| gen.add("set_camera_properties", bool_t, LEVEL.RUNNING, "Set the camera properties (brightness, contrast, hue, saturation)", False) | ||
| gen.add("brightness", double_t, LEVEL.RUNNING, "Target brightness", 0.5019607843137255, 0.0, 1.0) |
There was a problem hiding this comment.
This could be better if it is "Target brightness (Available only when set_camera_properties is true)".
Same on the "contrast", "hue" and "saturation".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntrast, hue and saturation.
In order to avoid situations like: #92