do not modify parameters unless explicitly set #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contrast, saturation, brightness, sharpness and focus parameters were recently added to usb_cam. This caused a regression (sigproc/robotic_surgery#17) whereby the default settings for a webcam are overridden in all cases by the hard-coded defaults in usb_cam. In the absence of a know good set of "default" values, leave the parameters unset unless the user has explicitly set them in the launch file.
|
In case this PR is not appropriate, I have also documented the previously undocumented parameters on the wiki page. |
rctoris
added a commit
that referenced
this pull request
Nov 18, 2014
do not modify parameters unless explicitly set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contrast, saturation, brightness, sharpness and focus parameters were recently added to usb_cam in b25c293. This caused a regression for us (sigproc/robotic_surgery#17) whereby, unless reset explicitly, the default settings for a webcam are overridden in all cases by the hard-coded defaults in usb_cam. This caused a previously working setup to start behaving very strangely.
It's probably near impossible to find a set of "known good" defaults for all cameras and so this PR changes the behaviour of the node to simply avoid setting the contrast, saturation, etc unless they've been explicitly set in the launch file. This is an application of the "principle of least surprise".