Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings, replace deprecated code #207

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Fix compiler warnings, replace deprecated code #207

merged 2 commits into from
Nov 23, 2022

Conversation

flynneva
Copy link
Collaborator

Signed-off-by: Evan Flynn [email protected]

@flynneva flynneva requested a review from twdragon November 21, 2022 04:37
@flynneva flynneva force-pushed the fix-compiler-warnings branch from ae2372d to 0437a29 Compare November 21, 2022 04:39
@flynneva
Copy link
Collaborator Author

@twdragon this was a nightmare to work through with all the ifdefs. Will be really happy once we implement that redesign you are talking about in #203

@flynneva flynneva force-pushed the fix-compiler-warnings branch 3 times, most recently from 7d0027b to e0ba850 Compare November 21, 2022 05:34
This was linked to issues Nov 21, 2022
libusb_cam.so: undefined reference #202
Closed
[Community assistance needed] libavcodec multi-version compatibility #203
Closed
libusb_cam.so: undefined reference "make -j4 -l4" failed #205
Closed
twdragon
twdragon reviewed Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@twdragon twdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flynneva I can be very appreciated if you could write here the links to libavcodec API changelogs or version headers from which, as you see, the necessary functions used here were changed/removed, to document the values you used to substitute the macros. In fact, libavcodec has still a C API, so we will not avoid working with conditioned compilation.

@flynneva
Copy link
Collaborator Author

flynneva commented Nov 22, 2022 •
edited
Loading

@twdragon I'll fix the focal issues tomorrow now for this PR. Side note I should have some time over the next week to work on the redesign / add some tests to this repo as well.

@flynneva flynneva force-pushed the fix-compiler-warnings branch from e0ba850 to cdfbe8b Compare November 22, 2022 17:04
@flynneva flynneva requested a review from twdragon November 22, 2022 17:11
@flynneva
Copy link
Collaborator Author

@twdragon just reminder this PR is for the ros2 branch...so not sure if these changes are applicable for the ROS 1 branch develop / if they can be backported.

twdragon
twdragon reviewed Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@twdragon twdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flynneva for sure here the backporting is needed. I will handle this in some time, probably, in the middle of December

@flynneva
Copy link
Collaborator Author

@twdragon if we focus on #203 and instead reuse the library and decouple it from a ROS-specific distro we might be able to skip the backporting step then, no?

twdragon
twdragon approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@twdragon twdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flynneva yes, I agree. I will think about how to refactor the main class and extract any libavcodec-related stuff from it :) Do you have any ready proposal about how the internal API should look like? Honestly, I did not look t it very thoroughly, but I will do it in a week or two.

@flynneva flynneva merged commit 77a774f into ros-drivers:ros2 Nov 23, 2022
@flynneva flynneva deleted the fix-compiler-warnings branch November 23, 2022 11:31
twdragon added a commit to twdragon/usb_cam that referenced this pull request Jan 23, 2023
@twdragon
Total refactoring
799044e 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
@knorth55 knorth55 mentioned this pull request Feb 20, 2023
Closed
twdragon added a commit to twdragon/usb_cam that referenced this pull request Feb 20, 2023
@twdragon
Total refactoring
97b43fe 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
twdragon added a commit to twdragon/usb_cam that referenced this pull request Feb 28, 2023
@twdragon
Total refactoring
576b9b6 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
twdragon added a commit to twdragon/usb_cam that referenced this pull request Feb 28, 2023
@twdragon
Total refactoring
b7d3b16 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
twdragon added a commit to twdragon/usb_cam that referenced this pull request Feb 28, 2023
@twdragon
Total refactoring
011eb48 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
knorth55 pushed a commit to knorth55/usb_cam that referenced this pull request Mar 1, 2023
@twdragon @knorth55
Total refactoring
cc7a751 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
@knorth55 knorth55 mentioned this pull request Mar 1, 2023
Merged
knorth55 pushed a commit to knorth55/usb_cam that referenced this pull request Mar 3, 2023
@twdragon @knorth55
Total refactoring
34382ad 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
knorth55 pushed a commit to knorth55/usb_cam that referenced this pull request Mar 3, 2023
@twdragon @knorth55
Total refactoring
a663562 
	- The node implemented as singleton with monopolistic device
	  access model (one node per device)
	- Moved and separated into different blocks the the code using
	  V4L2, ROS and FFMPEG APIs
	- Removed message pointers completely, the node uses runtime-
	  constant shared object addresses
	- Debugged FFMPEG decoder algorithm, removed memory leak.
	  Closes ros-drivers#211
	- Added (using @flynneva's code) the conditional compilation
	  directives to exploit properly versioned libavcodec API.
	  Closes ros-drivers#207
	- Closes ros-drivers#203
	- Added separated launch files to run the node and to test it
	  using image_view. Removed image_view from ROS dependencies.
	- Node parameters with convenient defaults moved from the
	  launch file to YML file for the parameter server
	- Documented parameter names and default values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twdragon twdragon twdragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
libavcodec multi-version compatibility
2 participants
@flynneva @twdragon