Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the deprecated decompression command #193

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

mad0x60
Copy link
Contributor

@mad0x60 mad0x60 commented Sep 2, 2022

The current ros2 image decompression command produces the following warning because it is deprecated:

[WARN] [1662133933.155713605] [rcl]: Found remap rule 'in/compressed:=image_raw/compressed'. This syntax is deprecated. Use '--ros-args --remap in/compressed:=image_raw/compressed' instead.
[WARN] [1662133933.155877454] [rcl]: Found remap rule 'out:=image_raw/uncompressed'. This syntax is deprecated. Use '--ros-args --remap out:=image_raw/uncompressed' instead.

This change updates the decompression command to match the most recent ROS2 format.

The current ros2 image decompression command produces the following warning because it is deprecated:
[WARN] [1662133933.155713605] [rcl]: Found remap rule 'in/compressed:=image_raw/compressed'. This syntax is deprecated. Use '--ros-args --remap in/compressed:=image_raw/compressed' instead.
[WARN] [1662133933.155877454] [rcl]: Found remap rule 'out:=image_raw/uncompressed'. This syntax is deprecated. Use '--ros-args --remap out:=image_raw/uncompressed' instead.

This change update to match the most recent ROS2 format
@mad0x60 mad0x60 changed the title update the deprecated uncompressed command update the deprecated decompression command Sep 2, 2022
@pitzer
Copy link

pitzer commented Sep 7, 2022

Thank you!

@flynneva flynneva self-requested a review September 7, 2022 05:19
@flynneva
Copy link
Collaborator

flynneva commented Sep 7, 2022

@mad0x60 lgtm, will wait for CI to pass before merging.

@flynneva flynneva merged commit f57957c into ros-drivers:ros2 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants