Bouncy version #128
Closed
Bouncy version #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng '' (/dev/video0) at 640x480 via mmap (mjpeg) at 30 FPS outbuf size mismatch. pic_size: 1036800 bufsize: 614400 ros-drivers#103
…something in the image message is wrong?) Had to make many changes to debug original issue which mainly was not created the img_ before trying to assign to it. It seems that ros2 run hides crashes silently so they are harder to debug. Every usb_cam method returns a bool but some things should throw exceptions instead. Many functions are run still without any checks on teh return value, which the throws would solve ros-drivers#103
…'t image_tools showimage?), but the frame rate is very slow ros-drivers#103
…pping the exposure time in low light ros-drivers#103
…aunch file the same as ros2 run usb_cam usb_cam_node __params:=src/usb_cam/config/params.yaml
…amera has short exposure, there may be a display issue with framerate- showimage.py shouldn't be used for high framerates, try imgui_ros next
|
thanks for getting things started here. Do you mind if we tackle the most recent ros2 version instead of bouncy? I feel like we should either get a version merged which is compliant with Foxy or ROS2 master. |
|
i just made a PR to @lucasw's bouncy branch with minor updates to get it functioning for foxy. tested on a usb camera and I can confirm it is functioning. if he merges that PR it should update this PR as well to work for foxy then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't touched this (or ros2) in a while, but it should be a reasonable starting point. A few things would be nice to see ported over to a noetic branch.
Looking at the number commits now it looks like an aggressive rebase -i would be good to squash this down.
Begins to address #103