Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 22, 2023

I cleaned-up the includes. It compiles and linters do not complain.

Fixes some items of #944

@codecov
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c3f614) 46.86% compared to head (7adf3ab) 46.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #943   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          41       41           
  Lines        3862     3862           
  Branches     1816     1816           
=======================================
  Hits         1810     1810           
  Misses        792      792           
  Partials     1260     1260           
Flag Coverage Δ
unittests 46.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...jectory_controller/joint_trajectory_controller.hpp 0.00% <ø> (ø)
...include/joint_trajectory_controller/tolerances.hpp 55.00% <ø> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 48.54% <ø> (ø)

@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-iron labels Dec 22, 2023
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a good idea!

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet some of these come from older cppcheck errors, let's see how the backports will do! :D

@bmagyar bmagyar merged commit f14396c into ros-controls:master Jan 2, 2024
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
(cherry picked from commit f14396c)
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
(cherry picked from commit f14396c)
@christophfroehlich christophfroehlich deleted the jtc/cleanup_includes branch January 2, 2024 15:33
bmagyar pushed a commit that referenced this pull request Jan 2, 2024
christophfroehlich added a commit that referenced this pull request Jan 3, 2024
(cherry picked from commit f14396c)
bmagyar pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants