Skip to content

Conversation

@egordon
Copy link
Contributor

@egordon egordon commented Jun 22, 2023

Addresses #671

Redux of #672 fix sent directly to master.
Requesting a back-port to humble if possible, as this seems to fix a bug noticed by anybody using closed-loop velocity or effort hardware control.

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@destogl destogl added the backport-humble Triggers PR backport to ROS 2 humble. label Jun 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.53%. Comparing base (e7f9962) to head (6919f38).
Report is 563 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   35.78%   36.53%   +0.75%     
==========================================
  Files         189        7     -182     
  Lines       17570      676   -16894     
  Branches    11592      357   -11235     
==========================================
- Hits         6287      247    -6040     
+ Misses        994      134     -860     
+ Partials    10289      295    -9994     
Flag Coverage Δ
unittests 36.53% <ø> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 194 files with indirect coverage changes

@destogl destogl merged commit 9ce288b into ros-controls:master Jun 26, 2023
mergify bot pushed a commit that referenced this pull request Jun 26, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jun 27, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jun 29, 2023
bmagyar pushed a commit that referenced this pull request Jul 2, 2023
mechwiz pushed a commit to mechwiz/ros2_controllers that referenced this pull request Jul 3, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jul 17, 2023
bmagyar pushed a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants