Skip to content

Minor cleanup & add TODOs for more #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Minor cleanup & add TODOs for more #320

wants to merge 1 commit into from

Conversation

@bmagyar
Copy link
Member

@bmagyar bmagyar commented Mar 31, 2022

No description provided.

@jaron-l
Copy link
Member

jaron-l commented Mar 31, 2022

How are TODOs used in this organization? Are they supposed to act as flags for minor things that anyone can pick up? I'm not sure how most people use them, but I've only used them as flags for work that needs to be done before the request is merged.

@destogl destogl marked this pull request as draft April 3, 2022 13:01
@destogl
Copy link
Member

destogl commented Apr 3, 2022

@jaron-l you are right, todos should be resolved before merge or is bigger changes are needed we should open an follow up issue describing it and referencing it in the code.

Other than that, this PR should be 'draft' because we will open a lot of issues from the todos.

(You can tackle some of them if you like)

@bmagyar bmagyar marked this pull request as ready for review April 25, 2022 17:59
@bmagyar bmagyar marked this pull request as draft April 25, 2022 17:59
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

This pull request is in conflict. Could you fix it @bmagyar?

3 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This pull request is in conflict. Could you fix it @bmagyar?

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This pull request is in conflict. Could you fix it @bmagyar?

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2023

This pull request is in conflict. Could you fix it @bmagyar?

@christophfroehlich christophfroehlich mentioned this pull request Dec 22, 2023
Open
8 tasks
@christophfroehlich
Copy link
Contributor

christophfroehlich commented Dec 27, 2023

I'll close this PR in favor of #944, let's discuss things there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@destogl destogl Awaiting requested review from destogl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmagyar @jaron-l @destogl @christophfroehlich