Fix parameter initialisation for galactic#199
Merged
bmagyar merged 4 commits intoros-controls:masterfrom Jun 18, 2021
nobleo:fix/galactic
Merged
Fix parameter initialisation for galactic#199bmagyar merged 4 commits intoros-controls:masterfrom nobleo:fix/galactic
bmagyar merged 4 commits intoros-controls:masterfrom
nobleo:fix/galactic
Conversation
This was referenced Jun 8, 2021
Member
|
Happy to incorporate all of these into Foxy too! |
Contributor
Author
|
Done, was actually only one other case. Took the liberty of fixing some other compiler warnings as well. |
bmagyar
requested changes
Jun 11, 2021
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
Member
|
@Timple if you leave editing by maintainers enabled next time I am happy to fix these up before merging. Now the ball is back in your court |
Contributor
Author
|
Whups, don't remember turning that off. Might be default. Edit: And I can't turn it even on? |
destogl
approved these changes
Jun 11, 2021
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
Just a small nit-pick if you like. Otherwise good!
Contributor
Author
|
All should be resolved now :) |
bmagyar
approved these changes
Jun 14, 2021
Member
|
Thanks! Merging once CI is through |
Contributor
Author
|
Would you mind kicking CI again? |
bmagyar
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per comment here: cyberbotics/webots_ros2#221 (comment)
I'm willing to expand this PR with the other controllers if these changes get accepted.