Use smart pointer of ctrl in GpsSensor and GpioCommandController tests #1658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I am updating the tests to use smart pointers for the gps broadcaster and gpio controller. This is similar to other tests e.g. test_pose_broadcaster.cpp
This to remove warning LifecycleNode is not shut down during test as shown in test log https://github.com/ros-controls/ros2_controllers/actions/runs/14608595520/job/40982298949. Issue is captured in #1656
Qualification
$ pre-commit install
$ colcon build --packages-select gpio_controllers gps_sensor_broadcaster
$ colcon test --packages-select gpio_controllers gps_sensor_broadcaster --event-handlers console_direct+
See that the warnings are no longer present
I am relatively new to ROS/2 and ros_control ecosystems, let me know if I am missing anything, thanks!
===
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)