-
Notifications
You must be signed in to change notification settings - Fork 411
Open
Labels
Description
Describe the bug
Several controllers have a cmd_vel_timeout parameter. But their units are inconsistent. Specifically, I found these:
| parameter | unit | type |
|---|---|---|
| tricycle_controller_parameter.yaml | milliseconds | int |
| omni_wheel_drive_controller_parameters.yaml | seconds | double |
| diff_drive_controller_parameter.yaml | seconds | double |
This is a bit confusing. Maybe we should unify their units.
Additionally, two controllers are using reference_timeout. This appears to be the same as cmd_vel_timeout. Maybe the parameter names should be unified as well?
reference_timeout: steering_controllers_library.yaml, mecanum_drive_controller.yaml
Expected behavior
Consistent units and types.
Environment:
- Version: master branch