Pr 190 merge resolved #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroller (ros-controls#190) (cherry picked from commit f43fa8a) # Conflicts: # README.md # ros2_control_demo_bringup/launch/rrbot.launch.py # ros2_control_demo_bringup/launch/rrbot_base.launch.py
destogl
requested changes
Oct 11, 2022
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
Thanks! We should do a switch here. Can you do that?
| package="ros2_control_test_nodes", | ||
| executable="publisher_joint_trajectory_controller", | ||
| name="publisher_joint_trajectory_controller", | ||
| executable="publisher_joint_trajectory_position_controller", |
Member
There was a problem hiding this comment.
We should here switch to ros2_controllers_test_nodes from ros2_controllers repository. Can you do that, please?
Member
|
I am not sure if I would continue with this change. Personally, find a very nice and descriptive example that the controller name is different than the type. The controller name should be rather descriptive and not correspond to its type. |
Member
|
After merging #232 this is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this MR resolved the mergify conflicts from #198
Best,
Haider