Skip to content

Chained controllers example#162

Closed
destogl wants to merge 3 commits intoros-controls:masterfrom
b-robotized-forks:chained-controllers-example
Closed

Chained controllers example#162
destogl wants to merge 3 commits intoros-controls:masterfrom
b-robotized-forks:chained-controllers-example

Conversation

@destogl
Copy link
Copy Markdown
Member

@destogl destogl commented Mar 24, 2022

To test the example, checkout the following branches and following dependencies:

ros-controls/ros2_control#667
ros-controls/ros2_controllers#318

Then, follow the instructions in README added in this PR.

@destogl destogl added the New example This PR is proposing a new example. label Mar 24, 2022
@destogl destogl self-assigned this Mar 24, 2022
@destogl destogl requested a review from bijoua29 March 24, 2022 19:33
@destogl destogl force-pushed the chained-controllers-example branch from 3c6eb16 to 056b06b Compare March 29, 2022 17:53
livanov93
livanov93 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good demo with multiple levels to showcase chainable controllers.

@destogl destogl requested a review from livanov93 April 26, 2022 20:23
livanov93
livanov93 previously approved these changes May 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All instructions were executed and the results were as expected.
Nice work once again!

@destogl destogl force-pushed the chained-controllers-example branch from 056b06b to de0662d Compare May 16, 2022 18:56
@pac48 pac48 mentioned this pull request Jun 26, 2022
Closed
@christophfroehlich christophfroehlich mentioned this pull request Feb 20, 2023
Closed
@christophfroehlich
Copy link
Copy Markdown
Member

christophfroehlich commented Feb 20, 2023

How can this be integrated? Can we merge ros-controls/ros2_controllers#318 into master or create an example without the need for custom ros2_controllers?

The status of ros-controls/ros2_controllers#318 is currently broken (no tf messages, and there is a merge conflict with master which I did not investigate this further)

@destogl
Copy link
Copy Markdown
Member Author

destogl commented Mar 16, 2023

No idea, we will probably have to kill this PR and get some better examples when more controllers get chainable options

@christophfroehlich christophfroehlich mentioned this pull request Jun 21, 2023
Closed
@saikishor saikishor mentioned this pull request Jun 25, 2023
Merged
@olivier-stasse
Copy link
Copy Markdown
Collaborator

olivier-stasse commented Sep 27, 2023

@christophfroehlich Maybe this PR can be closed as we already have it in example_12 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a10263790 a10263790 Awaiting requested review from a10263790

@bmagyar bmagyar Awaiting requested review from bmagyar

@rosterloh rosterloh Awaiting requested review from rosterloh

@Serafadam Serafadam Awaiting requested review from Serafadam

@ShawnSchaerer ShawnSchaerer Awaiting requested review from ShawnSchaerer

@bijoua29 bijoua29 Awaiting requested review from bijoua29

1 more reviewer

@livanov93 livanov93 livanov93 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@destogl destogl

Labels

New example This PR is proposing a new example.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@destogl @christophfroehlich @olivier-stasse @livanov93