This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Galactic: Pass time and period to update function#88
Merged
ahcorde merged 3 commits intoros-controls:masterfrom Oct 26, 2021
Merged
Galactic: Pass time and period to update function#88ahcorde merged 3 commits intoros-controls:masterfrom
ahcorde merged 3 commits intoros-controls:masterfrom
Conversation
bmagyar
changed the title
destogl
approved these changes
Sep 19, 2021
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
Looking good as per update on controller manager.
Member
Author
|
sure no problem |
Member
Author
|
@ahcorde could you please kick the CI to retry? The packages should be available from upstream now |
ahcorde
suggested changes
Oct 15, 2021
Collaborator
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
Do you mind to change this line in the gazebo_ros2_control/package.xml
<exec_depend>joint_state_controller</exec_depend>with
<exec_depend>joint_state_broadcaster</exec_depend>
Member
Author
|
Done! |
ahcorde
approved these changes
Oct 26, 2021
Collaborator
|
I will fix CI in other PR |
ksotebeer
pushed a commit
to ksotebeer/gazebo_ros2_control
that referenced
this pull request
Jun 14, 2022
* Pass time and period to update function * Use Galactic in GH action * joint_state_broadcaster in town
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following ros-controls/ros2_control#520 and ros-controls/ros2_controllers#241