Update with ros2_control: return types (hardware_interface and controller_interface) #28
Conversation
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
|
@chapulina friendly ping |
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
I just have one question for my own education, the PR looks perfectly fine. I did the other side of these changes over at ros2_control and then ros2_controllers. Happy for this to be merged whenever you are ready
| run: | | ||
| cd /home/ros2_ws/ | ||
| . /opt/ros/foxy/local_setup.sh | ||
| export CMAKE_PREFIX_PATH=$AMENT_PREFIX_PATH:$CMAKE_PREFIX_PATH |
There was a problem hiding this comment.
I had to do the same after struggling a lot with my dev environment and don't get why. Could you please enlighten me?
There was a problem hiding this comment.
This was addressed in colcon-ros long time ago I think it's a missing dependency in one of the packages.
There was a problem hiding this comment.
I've been chasing this for a while now, it's why I didn't want to release control_toolbox as I couldn't locally build it without applying hacks... I think it comes from control_msgs but it beats me what's missing...
There was a problem hiding this comment.
these are <exec_depend> https://github.com/ros-controls/control_msgs/blob/foxy-devel/control_msgs/package.xml#L19-L22
You don't need these lines in the CMakeLists.txt https://github.com/ros-controls/control_msgs/blob/foxy-devel/control_msgs/CMakeLists.txt#L5-L9
I will have a look to the rest of the packages, where are you facing this issue?
Return values have change in
hardware_interfaceandcontroller_interfaceSigned-off-by: ahcorde [email protected]