This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Added initial version of gazebo_ros2_control #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
bmagyar
suggested changes
May 28, 2020
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
Thanks for reviving this.
Are you planning to add a CI as well?
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
chapulina
reviewed
May 28, 2020
Collaborator
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
I haven't tried it out, but I just left some general comments about style, linting, etc.
gazebo_ros2_control/include/gazebo_ros2_control/default_robot_hw_sim.h
Outdated
Show resolved
Hide resolved
gazebo_ros2_control/include/gazebo_ros2_control/default_robot_hw_sim.h
Outdated
Show resolved
Hide resolved
gazebo_ros2_control/include/gazebo_ros2_control/default_robot_hw_sim.h
Outdated
Show resolved
Hide resolved
gazebo_ros2_control/include/gazebo_ros2_control/gazebo_ros2_control_plugin.h
Outdated
Show resolved
Hide resolved
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
bmagyar
reviewed
May 29, 2020
Signed-off-by: ahcorde <[email protected]>
bmagyar
approved these changes
Jun 1, 2020
chapulina
approved these changes
Jun 1, 2020
Collaborator
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
Thanks for addressing all my nitpicks! I just took another high-level look and it looks like a great start!
Collaborator
Author
|
Great! thank you for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the effort done by @ddengster in this PR ros-simulation/gazebo_ros_pkgs#1083 porting
gazebo_ros_controlto ROS 2. I have been working in reproduce the results. I tried "fix" some of the issue that I found in the code and comments@chapulina @Karsten1987
I know this is not a final solution. It's just make it work in ROS 2.
Signed-off-by: ahcorde [email protected]