windows build with python3 and up-to-date pip #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the Windows binaries currently fails due to an outdated pip version (the cryptography module requires rust; newer pip versions use a pre-compiled version instead of compiling it locally).
Updating pip in the docker-pyinstaller:python2 container failed, so I switched to python3 which seems to work. Additionally, building the python2 container is not possible anymore as Microsoft removed the download of the VCForPython27.msi file (but I did not try to fix this).
I only tested secretsdump_windows.exe, nothing more. So I'm not sure if switching to python 3 is currently a good idea. However, here are my changes, maybe it's helpful.