rOpenSci review changes

[boshek]

Below are the changes requested by the rOpenSci review here: ropensci/software-review#152

tidyhydat 0.3.0

NEW FEATURES

• New NEWS template!
• Moved station_number to first argument to facilitate piped analysis (Provide some tidy tools functionality #54)
• search_stn_name and search_stn_number now query both realtime and historical data sources and have tests for a more complete list (search_name and search_number should access hy_stations() and realtime_meta #56)
• With credential stored in .Renviron file, ws_token can successfully be called by ws_token().
• .onAttach() checks if HYDAT is downloaded on package load.

MINOR IMPROVEMENTS

• Significant function and argument name changes (see below)
• Adding rappdirs to imports and using to generate download path for download_hydat() (Database download #44)
• Adding rappdirs so that all the hy_* functions access hydat from rappdirs::user_data_dir() via hy_dir() (Database download #44)
• Revised and cleaned up documentation including two vignettes (Revise documentation #48)
• FULL MONTH evaluate to a logic (SED_MONTHLY_LOADS not working #51)
• All download tests are skipped on cran (download_realtime_ws tidying #53)
• Removed time limit for download_realtime_ws() with some documentation on actual limits. (3234c22)

BUG FIXES

• Add informative error message for a single missing station input (Missing station results in an uninformative error message #38)
• Fixed failing behaviour of get_ws_token (get_ws_token failing often #43)
• Fixed httr:content parsing error in download_realtime_ws. (httr::content generating some parsing errors #42)
• No longer trying to build .Rd file for .onload (Dealing with .onload differently #47)
• Fixed SED_MONTHLY_LOADS (SED_MONTHLY_LOADS not working #51)
• Wrapped download_realtime_ws examples in dontrun (Examples that run the webservice #52)

FUNCTION NAME CHANGES (#45)

• hy_agency_list <- AGENCY_LIST
• hy_annual_instant_peaks <- ANNUAL_INSTANT_PEAKS
• hy_annual_stats <- ANNUAL_STATISTICS
• hy_daily_flows <- DLY_FLOWS
• hy_daily_levels <- DLY_LEVELS
• hy_monthly_flows <- MONTHLY_FLOWS
• hy_monthly_levels <- MONTHLY_LEVELS
• hy_sed_daily_loads <- SED_DLY_LOADS
• hy_sed_daily_suscon <- SED_DLY_SUSCON
• hy_sed_monthly_loads <- SED_MONTHLY_LOADS
• hy_sed_monthly_suscon <- SED_MONTHLY_SUSCON
• hy_sed_samples <- SED_SAMPLES
• hy_sed_samples_psd <- SED_SAMPLES_PSD
• hy_stations <- STATIONS
• hy_stn_remarks <- STN_REMARKS
• hy_stn_datum_conv <- STN_DATUM_CONVERSION
• hy_stn_datum_unrelated <- STN_DATUM_UNRELATED
• hy_stn_data_range <- STN_DATA_RANGE
• hy_stn_data_coll <- STN_DATA_COLLECTION
• hy_stn_op_schedule <- STN_OPERATION_SCHEDULE
• hy_stn_regulation <- STN_REGULATION
• hy_agency_list <- AGENCY_LIST
• hy_reg_office_list <- REGIONAL_OFFICE_LIST
• hy_datum_list <- DATUM_LIST
• hy_version <- VERSION
• realtime_dd <- download_realtime_dd
• realtime_ws <- download_realtime_ws
• token_ws <- get_ws_token
• realtime_stations <- realtime_network_meta
• search_stn_name <- search_name
• search_stn_number <- search_number

ARGUMENT NAME CHANGES (#45)

• station_number <- STATION_NUMBER
• prov_terr_state_loc <- PROV_TERR_STATE_LOC