Skip to content

start adding editors to JSON#863

Merged
maelle merged 8 commits intomainfrom
editors
Oct 24, 2025
Merged

start adding editors to JSON#863
maelle merged 8 commits intomainfrom
editors

Conversation

@maelle
Copy link
Member

@maelle maelle commented Oct 8, 2024

Fix #767

@maelle
Copy link
Member Author

maelle commented Oct 8, 2024

not ready

@maelle maelle marked this pull request as ready for review October 10, 2024 10:10
@maelle
Copy link
Member Author

maelle commented Oct 10, 2024

@maelle
Copy link
Member Author

maelle commented Oct 17, 2024

@maelle
Copy link
Member Author

maelle commented Jan 9, 2025

@mfenner friendly reminder on deploy-preview-863--ropensci.netlify.app/blog/index.json 😸

@maelle
Copy link
Member Author

maelle commented Apr 8, 2025

@mfenner does https://deploy-preview-863--ropensci.netlify.app/es/blog/index.json look good? (the English feed has no translator example 🙂 )

@maelle
Copy link
Member Author

maelle commented Oct 23, 2025

@mfenner
Copy link

mfenner commented Oct 24, 2025

@maelle this looks good. I would consider using _roles rather than _role as the key to make it clearer that there can be multiple. In either case this is something I can implement in Rogue Scholar and I will start working on that.

@maelle
Copy link
Member Author

maelle commented Oct 24, 2025

@mfenner thanks, fixed! To clarify, can I already merge this or should I wait for the feature to be supported in Rogue Scholar? Thank you!

@mfenner
Copy link

mfenner commented Oct 24, 2025

Merging now is preferred from the Rogue Scholar perspective.

@maelle maelle merged commit df5488e into main Oct 24, 2025
4 checks passed
@maelle maelle deleted the editors branch October 24, 2025 09:40
@maelle
Copy link
Member Author

maelle commented Oct 24, 2025

Ok, done, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can one credit editors of posts on Rogue Scholar

2 participants