added the check for file size #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! But won’t this affect people who are not in the free trial and so limit those users who can go over the limit? Or is this a hard limit for all users?
…________________________________
From: John Muschelli <[email protected]>
Sent: Monday, August 5, 2019 11:15 PM
To: ropensci/googleLanguageR
Cc: Subscribed
Subject: [ropensci/googleLanguageR] added the check for file size (#62)
Got 400 error from https://stackoverflow.com/questions/51601697/invalid-argument-request-payload-size-exceeds-the-limit-10485760-bytes. Added a simple check on the file size for the request.
________________________________
You can view, comment on, or merge this pull request online at:
#62
Commit Summary
* added the check for file size
File Changes
* M R/speech-to-text.R<https://github.com/ropensci/googleLanguageR/pull/62/files#diff-0> (5)
Patch Links:
* https://github.com/ropensci/googleLanguageR/pull/62.patch
* https://github.com/ropensci/googleLanguageR/pull/62.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#62?email_source=notifications&email_token=AAYCPLG6SQZ4OSYRV4W7BVDQDCKARA5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDPMKMQ>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAYCPLBF6CMBYOBN2BOSWK3QDCKARANCNFSM4IJO6EUA>.
|
|
I don't know it's a hard limit for all users, but I have a dev account and
getting this limit with my API authorized.
Best,
John
…On Tue, Aug 6, 2019 at 3:26 AM Mark ***@***.***> wrote:
Thanks! But won’t this affect people who are not in the free trial and so
limit those users who can go over the limit? Or is this a hard limit for
all users?
________________________________
From: John Muschelli ***@***.***>
Sent: Monday, August 5, 2019 11:15 PM
To: ropensci/googleLanguageR
Cc: Subscribed
Subject: [ropensci/googleLanguageR] added the check for file size (#62)
Got 400 error from
https://stackoverflow.com/questions/51601697/invalid-argument-request-payload-size-exceeds-the-limit-10485760-bytes.
Added a simple check on the file size for the request.
________________________________
You can view, comment on, or merge this pull request online at:
#62
Commit Summary
* added the check for file size
File Changes
* M R/speech-to-text.R<
https://github.com/ropensci/googleLanguageR/pull/62/files#diff-0> (5)
Patch Links:
* https://github.com/ropensci/googleLanguageR/pull/62.patch
* https://github.com/ropensci/googleLanguageR/pull/62.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<
#62?email_source=notifications&email_token=AAYCPLG6SQZ4OSYRV4W7BVDQDCKARA5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDPMKMQ>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AAYCPLBF6CMBYOBN2BOSWK3QDCKARANCNFSM4IJO6EUA
>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#62?email_source=notifications&email_token=AAIGPLS2ID25RDPHRVWIZOTQDERSPA5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3UFR3A#issuecomment-518543596>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIGPLXNIENMXQLFKOJUJUDQDERSPANCNFSM4IJO6EUA>
.
|
|
@muschellij2 are you on a trail billing period with GCP? (Just based off the SO answer that indicates this is a factor) |
|
I do not know, but I've been using it for > 1 month, so I don't think on
trial billing.
Best,
John
…On Wed, Aug 7, 2019 at 3:20 AM Mark ***@***.***> wrote:
@muschellij2 <https://github.com/muschellij2> are you on a trail billing
period with GCP? (Just based off the SO answer that indicates this is a
factor)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#62?email_source=notifications&email_token=AAIGPLVYRU7GDCDII3FM6SDQDJZS7A5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3XOR4Q#issuecomment-518973682>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIGPLTO2ATRAM7WDCDRF3DQDJZS7ANCNFSM4IJO6EUA>
.
|
|
I also just added the ability to pass in a |
|
This is great! I remember thinking it would be cool for more integration with |
|
Not really sure how best to do that - a branch? reset?
Best,
John
…On Thu, Sep 12, 2019 at 10:41 PM Mark ***@***.***> wrote:
This is great! I remember thinkng it woudl be cool for more integration
with tuneR. Would you mind putting the Wave object integration in a
separate pull request? Still confirming the file size limit of the first
pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#62?email_source=notifications&email_token=AAIGPLRFVJAXDC7PDO4QFCTQJL4T5A5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TZSLQ#issuecomment-531077422>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIGPLQ5P7A6GNV3VABVUFTQJL4T5ANCNFSM4IJO6EUA>
.
|
|
Yes creating a branch for pull requests is best, I think library(usethis) has a helper function.
________________________________
From: John Muschelli <[email protected]>
Sent: Thursday, September 12, 2019 10:48 PM
To: ropensci/googleLanguageR
Cc: Mark; Comment
Subject: Re: [ropensci/googleLanguageR] added the check for file size (#62)
Not really sure how best to do that - a branch? reset?
Best,
John
On Thu, Sep 12, 2019 at 10:41 PM Mark ***@***.***> wrote:
This is great! I remember thinkng it woudl be cool for more integration
with tuneR. Would you mind putting the Wave object integration in a
separate pull request? Still confirming the file size limit of the first
pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#62?email_source=notifications&email_token=AAIGPLRFVJAXDC7PDO4QFCTQJL4T5A5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TZSLQ#issuecomment-531077422>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIGPLQ5P7A6GNV3VABVUFTQJL4T5ANCNFSM4IJO6EUA>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#62?email_source=notifications&email_token=AAYCPLEX3OTF2RADGGOZSPTQJL5P5A5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TZ3WY#issuecomment-531078619>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAYCPLECKGMOMR5V3AD2UULQJL5P5ANCNFSM4IJO6EUA>.
|
|
OK - it'll be at least a week or 2 I believe.
Best,
John
…On Fri, Sep 13, 2019 at 7:19 AM Mark ***@***.***> wrote:
Yes creating a branch for pull requests is best, I think library(usethis)
has a helper function.
________________________________
From: John Muschelli ***@***.***>
Sent: Thursday, September 12, 2019 10:48 PM
To: ropensci/googleLanguageR
Cc: Mark; Comment
Subject: Re: [ropensci/googleLanguageR] added the check for file size (#62)
Not really sure how best to do that - a branch? reset?
Best,
John
On Thu, Sep 12, 2019 at 10:41 PM Mark ***@***.***> wrote:
> This is great! I remember thinkng it woudl be cool for more integration
> with tuneR. Would you mind putting the Wave object integration in a
> separate pull request? Still confirming the file size limit of the first
> pull request.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#62?email_source=notifications&email_token=AAIGPLRFVJAXDC7PDO4QFCTQJL4T5A5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TZSLQ#issuecomment-531077422
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAIGPLQ5P7A6GNV3VABVUFTQJL4T5ANCNFSM4IJO6EUA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<
#62?email_source=notifications&email_token=AAYCPLEX3OTF2RADGGOZSPTQJL5P5A5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TZ3WY#issuecomment-531078619>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/AAYCPLECKGMOMR5V3AD2UULQJL5P5ANCNFSM4IJO6EUA
>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#62?email_source=notifications&email_token=AAIGPLW5GZHKCVTGLBEJXATQJNZLFA5CNFSM4IJO6EUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UXIZI#issuecomment-531199077>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIGPLS5ED3Q6SC5SHT5FUDQJNZLFANCNFSM4IJO6EUA>
.
|
|
Sorry it took so long ot merge, but pushing for a CRAN release now @muschellij2 - I've added a credit to you in the description, thanks a lot for the pull requests. |
MarkEdmondson1234
added a commit
that referenced
this pull request
Apr 14, 2020
|
Any time - thanks for the great package. Totally forgot about this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got 400 error from https://stackoverflow.com/questions/51601697/invalid-argument-request-payload-size-exceeds-the-limit-10485760-bytes. Added a simple check on the file size for the request.