Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CITATION instructions: 'citEntry' -> 'bibentry'; fixes #604 #609

Merged
merged 10 commits into from
Feb 14, 2023
Merged

update CITATION instructions: 'citEntry' -> 'bibentry'; fixes #604 #609

merged 10 commits into from
Feb 14, 2023

Conversation

mpadge
Copy link
Member

@mpadge mpadge commented Feb 9, 2023

No description provided.

@mpadge mpadge requested a review from maelle February 9, 2023 12:50
maelle
maelle requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two questions + the Spanish version is missing.

Thanks a ton!!

pkg_building.Rmd Show resolved Hide resolved
pkg_building.Rmd
note = "R package version 1.0.0",
year = "2022",
url = "https://github.com/ropensci/dynamite"
)
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to update https://ropensci.org/blog/2021/02/16/package-citation/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but all of this stuff suggests as first action usethis::use_citation, and that's currently wrong 😱 . so we first have to wait for that to be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ropensci/roweb3#484

@mpadge mpadge requested a review from maelle February 9, 2023 13:06
@maelle maelle mentioned this pull request Feb 9, 2023
Closed
@maelle maelle requested a review from yabellini February 9, 2023 13:22
@mpadge mpadge mentioned this pull request Feb 9, 2023
Merged
maelle
maelle approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! (I reviewed the English version only)

yabellini
yabellini reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.

pkg_building.es.Rmd Outdated Show resolved Hide resolved
pkg_building.es.Rmd Outdated Show resolved Hide resolved
@mpadge mpadge merged commit 5ec816f into main Feb 14, 2023
@mpadge mpadge deleted the citation branch February 14, 2023 11:28
@mpadge
Copy link
Member Author

mpadge commented Feb 14, 2023

Thanks @yabellini!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yabellini yabellini yabellini approved these changes

@maelle maelle maelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mpadge @yabellini @maelle @helske