Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov how-to in CI section #484

Merged
merged 10 commits into from
Jun 23, 2022
Merged

Codecov how-to in CI section #484

merged 10 commits into from
Jun 23, 2022

Conversation

ewallace
Copy link
Contributor

@ewallace ewallace commented Jun 23, 2022

  • Explain how to use Codecov in coverage / continuous integration section.
  • Added brief "What is CI" section

As discussed with @maelle and @mpadge in
https://discuss.ropensci.org/t/staff-admin-team-codecov/2982/3
ropensci/tidyqpcr#191

@ewallace ewallace changed the base branch from master to dev June 23, 2022 09:22
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @ewallace for this clear improvement in both structure and wording. Our Dev Guide is intended to be a community effort, and we particularly appreciate this kind of direct engagement with its ongoing development. I've made a couple of minor suggestions, and only the one not-really-minor request for change. Happy to iterate and discuss further as you see fit.

pkg_ci.Rmd Outdated Show resolved Hide resolved
pkg_ci.Rmd Outdated Show resolved Hide resolved
pkg_ci.Rmd Outdated Show resolved Hide resolved
pkg_ci.Rmd Outdated Show resolved Hide resolved
pkg_ci.Rmd Outdated Show resolved Hide resolved
@maelle
Copy link
Member

maelle commented Jun 23, 2022

Thank you! Two other comments: please add yourself to

_We are thankful for all authors, reviewers and guest editors for helping us improve the system and this guide over the years. Thanks also to the following persons who made contributions to this guide and its previous incarnations: [Katrin Leinweber](https://github.com/katrinleinweber), [John Baumgartner](https://github.com/johnbaums), [François Michonneau](https://github.com/fmichonneau), [Christophe Dervieux](https://github.com/cderv), [Lorenzo Busetto](https://github.com/lbusett), [Ben Marwick](https://github.com/benmarwick), [Nicholas Horton](https://github.com/nicholasjhorton), [Chris Kennedy](https://github.com/ck37), [Mark Padgham](https://github.com/mpadge), [Jeroen Ooms](https://github.com/jeroen), [Sean Hughes](https://github.com/seaaan), [Jan Gorecki](https://github.com/jangorecki), [Joseph Stachelek](https://github.com/jsta), [Dean Attali](https://github.com/daattali), [Julia Gustavsen](https://github.com/jooolia), [Nicholas Tierney](https://github.com/njtierney), [Rich FitzJohn](https://github.com/richfitz), [Tiffany Timbers](https://github.com/ttimbers), [Hilmar Lapp](https://github.com/hlapp), [Miles McBain](https://github.com/milesmcbain), [Bryce Mecum](https://github.com/amoeba), [Jonathan Carroll](https://github.com/jonocarroll/), [Carl Boettiger](https://github.com/cboettig/), [Florian Privé](https://github.com/privefl), [Stefanie Butland](https://github.com/stefaniebutland), [Daniel Possenriede](https://github.com/dpprdan/), [Hadley Wickham](https://github.com/hadley/), [Mauro Lepore](https://github.com/maurolepore/), [Matthew Fidler](https://github.com/mattfidler), [Luke McGuinness](https://github.com/mcguinlu), [Aaron Wolen](https://github.com/aaronwolen), [Indrajeet Patil](https://github.com/IndrajeetPatil), [Kevin Wright](https://github.com/kwstat), [Will Landau](https://github.com/wlandau), [Hugo Gruson](https://github.com/Bisaloo),
and a news item to

@ewallace
Copy link
Contributor Author

Thanks @mpadge and @maelle - I've made the changes requested, HTH.

Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much!

appendix.Rmd Outdated Show resolved Hide resolved
@maelle maelle merged commit 6a71592 into ropensci:dev Jun 23, 2022
@ewallace ewallace deleted the patch-1 branch June 23, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants