-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codecov how-to in CI section #484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @ewallace for this clear improvement in both structure and wording. Our Dev Guide is intended to be a community effort, and we particularly appreciate this kind of direct engagement with its ongoing development. I've made a couple of minor suggestions, and only the one not-really-minor request for change. Happy to iterate and discuss further as you see fit.
Thank you! Two other comments: please add yourself to Line 72 in 55eba7e
Line 6 in 55eba7e |
Co-authored-by: mark padgham <[email protected]>
Co-authored-by: mark padgham <[email protected]>
Co-authored-by: mark padgham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much!
As discussed with @maelle and @mpadge in
https://discuss.ropensci.org/t/staff-admin-team-codecov/2982/3
ropensci/tidyqpcr#191