Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI chapter updates #377

Merged
merged 2 commits into from
Jan 14, 2022
Merged

CI chapter updates #377

merged 2 commits into from
Jan 14, 2022

Conversation

noamross
Copy link
Contributor

  • Soft reccommend GitHub Actions, pointing to other resources
  • Use "Operating Systems" rather than "platforms" as "platforms" can refer to different CI services.
  • Separate "which service" from "which operating system" because most services now handle different operating systems.

 - Soft reccommend GitHub Actions, pointing to other resources
 - Use "Operating Systems" rather than "platforms" as "platforms" can refer to different CI services.
 - Separate "which service" from "which operating system" because most services now handle different operating systems.
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

Copy link

@ldecicco-USGS ldecicco-USGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@noamross noamross merged commit 2af0157 into dev Jan 14, 2022
@noamross noamross deleted the ci-updates branch January 14, 2022 14:59
@maelle
Copy link
Member

maelle commented Jan 14, 2022

@noamross could you please also update the changelog? Sorry for forgetting earlier

noamross pushed a commit that referenced this pull request Jan 14, 2022
@noamross
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants