Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] in linking reviewer approval template #548

Closed
mpadge opened this issue Sep 20, 2022 · 2 comments
Closed

[BUG] in linking reviewer approval template #548

mpadge opened this issue Sep 20, 2022 · 2 comments

Comments

@mpadge
Copy link
Member

mpadge commented Sep 20, 2022

Should be linked here at the end of 8.2.3 but isn't. Source has the correct link:

dev_guide/softwarereview_editor.Rmd

Line 114 in 7063a74

- Upon changes being made, change the review status tag to `5/awaiting-reviewer-response`, and request that reviewers indicate approval with the [reviewer approval template]{#approval2template}.

@mpadge
Copy link
Member Author

mpadge commented Sep 20, 2022

Hmm ... template is also linked in Reviewer Chapter, with identical form. It works there, yet not in the editor chapter?

@mpadge
Copy link
Member Author

mpadge commented Sep 20, 2022

Nope, form is not identical. The softwarereview_editor link is in curly braces, not brackets. Now easy to fix.

mpadge added a commit to mpadge/dev_guide that referenced this issue Sep 20, 2022
@mpadge
fix approval2template link; closes ropensci#548
649f18d
@maelle maelle closed this as completed in 35525f8 Sep 20, 2022
mpadge added a commit to mpadge/dev_guide that referenced this issue Sep 20, 2022
@mpadge
update booknews with ropensci#547, ropensci#548
2e81222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpadge