#42 - Fixed the safe_hex_color function.

[kylevoyto]

#42 - Fixed the safe_hex_color function.

Description

The safe_hex_color function used to generate a color using the same approach as the Python faker method. I modified the function to generate only the 216 colors referenced in https://en.wikipedia.org/wiki/Web_colors#Web-safe_colors. I use the approach, "For this method I think generating three separate hex digits and duplicating them and concatenating them would be a cleaner implementation", referenced in ropensci/software-review#94.

Related Issue

fix #42. Also #18 should already be fixed from a previous commit.

Example

res <- ch_safe_hex_color(100000)
plot(table(res) / length(res))

Many tests were added for the ColorProvider functions. The few below reflect the safe_hex_color change:
safe_hex_regex <- "^#([0369CF])\1([0369CF])\2([0369CF])\3$"
expect_match(ch_safe_hex_color(), safe_hex_regex, ignore.case = TRUE)
expect_match(ch_safe_hex_color(12), safe_hex_regex, ignore.case = TRUE)
expect_true(all(nchar(ch_safe_hex_color()) == 7))
expect_true(all(nchar(ch_safe_hex_color(12)) == 7))

[codecov-io]

Codecov Report

Merging #76 into master will increase coverage by 0.49%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   61.99%   62.48%   +0.49%     
==========================================
  Files          43       43              
  Lines        1113     1117       +4     
==========================================
+ Hits          690      698       +8     
+ Misses        423      419       -4

Impacted Files	Coverage Δ
R/color-provider.R	93.54% <100%> (+0.95%)	⬆️
R/color.R	100% <0%> (+10.52%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d20338...513ad87. Read the comment docs.

[sckott]

thanks again @kylevoyto thanks for adding all those tests!