Issue34 #48
Merged
Issue34 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no change to the oobag denominator during tree growing yet, but this commit sets up the inputs of grow functions for that.
because oobag denom is fixed after trees are grown
Now that oobag denom is managed by grow, these pointers are not needed. The only feature impacted by this change is computation of oobag prediction accuracy every X trees. It used to use dynamic oobag denom but now it's static, which means prediction accuracy looks much worse with smaller tree counts. This change makes no meaningful difference in forests other than computational efficiency during prediction.
this can occur is sample fraction is close to 1. This input doesn't matter when prediction is happening, but we need a vector to match cpp type expectations and avoid R crash.
using these functions with high values of sample fraction risks getting an empty value for oobag rows, which would end up getting filled with a dummy vector of length 1. This should not happen is sample fraction is kept at or below 9/10 and sample size is reasonable.
re-do initialization at time of prediction if the tree isn't grown with oobag error.
This was referenced Mar 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puts construction of
oobag_denomexclusively ingrow, fixing #34