Skip to content

Commit

Permalink
prep for cran submission
Browse files Browse the repository at this point in the history
  • Loading branch information
bcjaeger committed Jan 9, 2024
1 parent f9afe2e commit d93c186
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 26 deletions.
39 changes: 39 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,42 @@
## Version 0.1.2

I have run R CMD check and have also checked for memory leaks using R CMD check --use-valgrind aorsf_0.1.2.tar.gz.

### Valgrind check results (abbreviated)

==2062== LEAK SUMMARY:
==2062== definitely lost: 0 bytes in 0 blocks
==2062== indirectly lost: 0 bytes in 0 blocks
==2062== possibly lost: 0 bytes in 0 blocks
==2062== still reachable: 144,402,034 bytes in 45,757 blocks
==2062== suppressed: 0 bytes in 0 blocks

==2062== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

### R CMD check results


### R CMD check results

Duration: 2m 56.3s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

R CMD check succeeded

### Downstream dependencies

I have also run R CMD check on downstream dependencies of `aorsf`:

- collapse
- data.table
- lifecycle
- R6
- Rcpp
- utils

All packages passed.

## Version 0.1.1

Update, October 25: Thank you for helping me with this. I have tidied up threads and avoided usage of the `data.table` functions that were creating possible memory leaks. I have checked this submission locally with valgrind and on rhub, with both indicating 0 memory leaks. However, if this submission does not pass on your end, I would like to request an extension on the October 28th deadline.
Expand Down
44 changes: 18 additions & 26 deletions man/orsf.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d93c186

Please sign in to comment.