This repository has been archived by the owner on Nov 10, 2024. It is now read-only.
Provide appropriate access to grouping columns for ts_plot() #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for the update. Don't worry by the tests: it uses a special variable to pick up the credentials that I have in my computer and on the CI on github. I am now allowing the checks to run, and I will review it shortly. |
- Skip test if dplyr is not installed - Use a column present in rt - Do not duplicate test (ts_plot calls ts_data) - Add fixture for vcr.
|
I modified the test because rt didn't have screen_name. I also slightly modified the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #724.
@llrs I added tests per your request in #726 but I'm afraid I don't understand the testing infrastructure enough to actually run it on my computer. I see the use of
vcrto store the results, but I don't know how to add my own token to the request so the test actually runs.