Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile setup improvements #732

Merged
merged 43 commits into from
Jun 10, 2024
Merged

Dockerfile setup improvements #732

merged 43 commits into from
Jun 10, 2024

Conversation

JulianPasquale
Copy link
Contributor

@JulianPasquale JulianPasquale commented May 27, 2024 •
edited
Loading

Description:

  • Update and optimizeDockerfile to run in production. It reduces image size by using only necessary dependencies, a ruby-slim image and improves memory management by using jemalloc.
  • Add Dockerfile.dev for local development. It keeps the Node binaries so we can take advantage of live reloading.
  • Improve docker-compose. Now we don't need to have use volumes for live reloading as we can use the watch feature, and the web and js processes run in a single service, enabled by foreman.
  • Add docker-compose.test , configured to run specs with it (has chrome-server service and options needed only in test environment).
  • Improve bin scripts to run with docker.
  • Add docs to explain new changes and how to use them.

JulianPasquale and others added 30 commits December 1, 2023 11:07
@JulianPasquale
WIP
3a80017
@PerezIgnacio
WIP: Improve dockerfile, add version for node, yarn
cd8b02a
@smerlo
bundler changes
a458d08
@guillermoap
Add ENTRYPOINT to dockerfile
10789f7
@PerezIgnacio
Fix tests with docker
fa1c8d2
@JulianPasquale
Update docker-compose. Do we need to precomiple assets to access the …
e51fee7 
…admin?
@PerezIgnacio
Merge branch 'main' into improve-dev-docker
2169cd7
@PerezIgnacio
Revert "Upgrade to Ruby 3.3 (#571)"
271ca0f 
This reverts commit 1f224de.
@PerezIgnacio
Add support for capybara tests with docker
8f5518f
@PerezIgnacio
Change depends_on to web service in compose
de3c6d7
@smerlo
docker compose capybara config
9e1f93c
@PerezIgnacio
Config in spec_helper
775c5ed
@JulianPasquale
Merge branch 'main' into improve-dev-docker
73ae605
@JulianPasquale
Start with prod Dockerfile
917d96d
@PerezIgnacio
Improve prod docker file
b999a3f
@JulianPasquale
Progress reducing final image size
9f455e3
@PerezIgnacio
Use slim image, remove spring, fixes in dockerfile
41cbedd
@guillermoap
Remove bloated floders from docker build
f7d7861
@smerlo
add jemalloc to dockerfile.prod
8103466
@smerlo
change docker compose
618164a
@PerezIgnacio
Add back ruby 3.3.0
458f168
@PerezIgnacio
Fix dev dockerfile
4f7dc3b
@PerezIgnacio
Merge branch 'main' into improve-dev-docker
10463ec
@PerezIgnacio
Use bin/dev in docker-compose
825967c
@PerezIgnacio
Fixes
aec76c5
@PerezIgnacio
Add docs
d0a1713
@JulianPasquale
Use watch in docker-compose
1c2f6c0
@PerezIgnacio
Separate chrome server to different dockercompose
0c4e291
@axelpontetto
Update bin files to execute tests without running the server
7903097
@JulianPasquale
Remove compose dependency + add -rm option to rspec command
ad9db6b
@JulianPasquale JulianPasquale marked this pull request as ready for review May 28, 2024 15:14
@JulianPasquale JulianPasquale requested a review from a team May 28, 2024 15:14
santib
santib reviewed Jun 3, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
santib
santib reviewed Jun 3, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
santib
santib reviewed Jun 3, 2024
View reviewed changes
bin/docker-entrypoint Outdated Show resolved Hide resolved
santib
santib reviewed Jun 3, 2024
View reviewed changes
bin/helpers.rb Outdated Show resolved Hide resolved
santib
santib reviewed Jun 3, 2024
View reviewed changes
docs/docker.md Outdated Show resolved Hide resolved
santib
santib reviewed Jun 3, 2024
View reviewed changes
docs/docker.md Outdated Show resolved Hide resolved
santib
santib approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@santib santib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 this is awesome

@santib santib requested a review from a team June 4, 2024 13:51
lauperalti
lauperalti approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@lauperalti lauperalti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 💪 ! Excellent documentation and step by step guide.

bin/rspec Outdated Show resolved Hide resolved
Dockerfile.dev Show resolved Hide resolved
Dockerfile.dev Outdated Show resolved Hide resolved
@JulianPasquale JulianPasquale merged commit 8dc8e16 into main Jun 10, 2024
5 of 6 checks passed
@JulianPasquale JulianPasquale deleted the improve-dev-docker branch June 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smerlo smerlo smerlo left review comments

@santib santib santib approved these changes

@lauperalti lauperalti lauperalti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JulianPasquale @santib @lauperalti @smerlo @PerezIgnacio @guillermoap @axelpontetto