Add CD with github actions

[brunoparma88]

Board:

• Promoters Ticket

---

Description:

Why:

To streamline app deployment, enhancing team efficiency. Utilizing GitHub Actions centralizes processes, aiding devs familiar with the repo.

Documentation:

GitHub CD Documentation

[santib]

maybe if we comment this part the job doesn't run by default (what we want) and in the docs we can clarify that they need to uncomment it if they are willing to deploy to AWS?

[santib]

Similar to what we did here:

rails_api_base/.github/workflows/update_knapsack_report.yml

Lines 3 to 8 in f999c2f

	on:
	workflow_dispatch:
	# This workflow should be scheduled at certain intervals
	# schedule:
	# - cron: '0 0 1 */3 *'
	# The above cron would schedule it every 3 months. Replace with the wanted periodicity.

And we can even add worfklow_dispatch so that it can be manually triggered

[santib]

Great! LGTM 🤩

[santib]

The only doubt I have is if having the on section completely commented might make the GHA invalid

Other option would be doing the same as here

on:
  workflow_dispatch:
  # Uncomment and add the necessary branches to enable automatic deployment on AWS
  # push:
    # branches:
      # - main

[JulianPasquale]

If I understand correctly, this requires us to create a Github environment and a branch with the exact same name. If we are forcing any naming convention, we should add it to the docs

[JulianPasquale]

I'm also wondering if we should keep track of all the releases using the "Github releases" feature, and I think that relies on tagging instead of branch pushes

• https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository
• https://github.com/marketplace/actions/create-a-release-in-a-github-action

[brunoparma88]

Using "GitHub releases" based on tagging could be an interesting idea to track all releases. It offers a structured approach with release notes and contributors. However, it requires a different setup from the process investigated in this PR. Let's consider exploring this in a separate card and PR for future enhancements.

[JulianPasquale]

Any reason why we do this manually instead of using docker/build-push-action? I think you can get the imageID as well using it

[JulianPasquale]

These secrets are environment specific right? Maybe we should clarify that these are not repo level settings, but environment level

[santib]

on:
  push:
    branches:
      - main
      - dev

you can use a yaml block code here

[santib]

otherwise it looks like this:

[lauperalti]

👏 Looks Great!

[mwolman]

Grammarly suggestion

Suggested change

	The GitHub Actions workflow will automatically deploy to the correct environment based on the branch being pushed to. The branch `main` will always be linked to the `production` environment, while other branches will use their own names as the environment. All environments added in GitHub must have the same name as the branches.
	The GitHub Actions workflow will automatically deploy to the correct environment based on the branch being pushed to. The branch `main` will always be linked to the `production` environment, while other branches will use their names as the environment. All environments added in GitHub must have the same name as the branches.

[mwolman]

Grammarly suggestion

Suggested change

	To set up the GitHub Actions workflow for continuous deployment to AWS, you need to modify the existing cd.yml file in the .github/workflows directory of your GitHub repository.
	To set up the GitHub Actions workflow for continuous deployment to AWS, you need to modify the existing cd.yml file in your GitHub repository's `.github/workflows` directory.