Improve failure output for commands #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves failure handling and output for two types of commands: 1. ones that use ad hoc playbooks 2. vault related In both cases trellis-cli wasn't outputting useful error output from the underlying Ansible commands making it harder to troubleshoot. The solution is to capture the output and conditionally display the error output when the underlying command fails.
3 tasks
swalkinshaw
deleted the
improve-failure-output-for-commands-using-adhoc-playbooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300
This improves failure handling and output for two types of commands:
In both cases trellis-cli wasn't outputting useful error output from the underlying Ansible commands making it harder to troubleshoot.
The solution is to capture the output and conditionally display the error output when the underlying command fails.