Use type declarations and bump minimum PHP version to 7.4 #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knowler
force-pushed
the
type-declarations
branch
from
eb8e7ae to
fd5cf78
Compare
Breaks support for PHP 7.3.
knowler
force-pushed
the
type-declarations
branch
from
fd5cf78 to
938e41c
Compare
|
let's pass on the type declarations for now (unless laravel 9.x is doing this), but can we get a separate PR opened for dropping PHP 7.3 support? |
|
Closed in favour of #2925. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses type declarations that are supported by PHP 7.4+ where it and therefore increases the project’s supported PHP version to 7.4.
Ref roots/bedrock#619: