Fix vendor extracted js modules not available in editor.

[oxyc]

See #2370

I know sage has always registered the scripts at the same time they're enqueued so this solution might not be great to everyone.

Another option is to somehow fix it in the laravel mix config I guess.

[Log1x]

editor.js should not be enqueued on the frontend.

By default, I do not enqueue vendor.js as it is not required with the default behavior, but can simply be enqueued in enqueue_block_editor_assets the same as it is in wp_enqueue_scripts.

This has been taken into consideration and in the future– it would be ideal if all vendor dependencies related to editor.js are bundled with it despite .extract() – but it is not high on the todo list at the moment (and probably won't be considered until webpack 5)

[oxyc]

editor.js should not be enqueued on the frontend.

No of course not, this PR only registers it.

If you prefer duplicating the wp_enqueue_script line rather than separating registrations from enqueues I'm fine changing the PR.

As for leaving it as it is, I'd vote no as you can't write es6 code without having to manually add vendor.js as a dependency. Something which isn't very straightforward to figure out since the "bug" doesn't issue any warnings/notices and comes from a babel runtime not mentioned anywhere in the sage code.

[Log1x]

No of course not, this PR only registers it.

Ahh I see now. Sorry, I had initially replied on my phone.

As for leaving it as it is, I'd vote no

I agree with you. We should add it in, even if commented out by default (open to opinions) – at least until we have vendor splitting between the app and editor.

I would like to stick to using the original method of wp_enqueue_script, though.

More or less, just keep the original but change to something along the lines of (untested):

add_action('enqueue_block_editor_assets', function () {
    if ($manifest = asset('scripts/manifest.asset.php')->get()) {
        wp_enqueue_script('sage/vendor.js', asset('scripts/vendor.js')->uri(), $manifest['dependencies'], $manifest['version']);
        wp_enqueue_script('sage/editor.js', asset('scripts/editor.js')->uri(), $manifest['dependencies'], $manifest['version']);

        wp_add_inline_script('app/vendor.js', asset('scripts/manifest.js')->contents(), 'before');
    }

    wp_enqueue_style('sage/editor.css', asset('styles/editor.css')->uri(), false, null);
}, 100);

[oxyc]

@Log1x I updated the PR but can't really see a good way to have it commented out since:

1. I think we should have it as a dependency of sage/editor.js otherwise I can potentially see some third party plugin breaking things. If you disagree I can of course remove it as a dependency.
2. As the inlined manifest needs to come before sage/vendor.js we'd have to provide a commented out version of that too.

[Log1x]

I'm sorry! I completely forgot about this PR til today. I have added similar changes to #2413 so I'm closing this as it'll get merged it with that.