Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§‘β€πŸ’» Append the original exception message to the skipped provider exception #398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Log1x
Copy link
Member

@Log1x Log1x commented Aug 24, 2024

No description provided.

Copy link

@montchr montchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've been using this in an extended Application class and it is a vast improvement over the current behavior πŸ™‚. Eventually, it would be great to expose a stack trace from the problematic provider too.

@QWp6t
Copy link
Member

QWp6t commented Sep 26, 2024

Thank you! I've been using this in an extended Application class and it is a vast improvement over the current behavior πŸ™‚. Eventually, it would be great to expose a stack trace from the problematic provider too.

You should be able to get a stack trace because it passes the the encountered exception as the $previous argument. Is that not working?

@Log1x
Copy link
Member Author

Log1x commented Sep 27, 2024

You should be able to get a stack trace because it passes the the encountered exception as the $previous argument. Is that not working?

No, it doesn't work which is why I did this fix. It's otherwise a bit frustrating and has caused a good bit of support requests since the provider skipping behavior was implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants