Skip to content

sandbox: Warn if /etc/resolv.conf is a symlink to a file outside /etc or /run #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giuseppe merged 1 commit into from
Mar 25, 2020
Merged

sandbox: Warn if /etc/resolv.conf is a symlink to a file outside /etc or /run #187

giuseppe merged 1 commit into from
Mar 25, 2020

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 25, 2020

Close #116

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Mar 25, 2020

@giuseppe PTAL

@AkihiroSuda AkihiroSuda added this to the v1.0.0 milestone Mar 25, 2020
giuseppe
giuseppe approved these changes Mar 25, 2020
View reviewed changes
Copy link
Collaborator

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit b797921 into rootless-containers:master Mar 25, 2020
@pcahyna
Copy link

pcahyna commented Sep 18, 2020

This will not work if /etc/resolv.conf is a symlink to /var/run/NetworkManager/resolv.conf and /var/run is a symlink to /run. (realpath(3) returns only the final path, but here the problem is in the intermediate symlink in the symlink hieararchy.)

@pcahyna pcahyna mentioned this pull request Sep 18, 2020
Merged
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Sep 18, 2020

Could you open an issue?

By "this will not work", do you just mean the warning isn't printed, or is something actually non-functional?

@pcahyna
Copy link

pcahyna commented Sep 18, 2020

I mean, warning is not printed, and DNS resolving is non-functional (which is what the warning should warn about).

@pcahyna pcahyna mentioned this pull request Sep 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

sandbox should be disabled when resolv.conf is a symlink to a file outside /etc or /run ?

3 participants

@AkihiroSuda @pcahyna @giuseppe