[RDF][v6.38] Fix an iterator invalidation in RDF snapshots #20505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup of the fix root-project#20352 for issue root-project#20320: When snapshot with variations is run with JIT-ted filters, the computation graph first needs to be JIT-ted before reading Defines or Filters. In the fix for that case, an iterator invalidation on push_back caused crashes, because vector.reserve() had been called with the wrong size. Here, the size is corrected, but more importantly, instead of saving the iterator, the shared_ptr it points to is saved. This makes the code independent of the underlying storage. (cherry picked from commit 886abae)
(cherry picked from commit c7b4143)
hageboeck
force-pushed
the
v6.38_snapshotCrash
branch
from
f1ae71f to
b4fdcba
Compare
Test Results 21 files 21 suites 3d 20h 59m 29s ⏱️ Results for commit b4fdcba. ♻️ This comment has been updated with latest results. |
hageboeck
requested review from
bellenot,
martamaja10 and
vepadulano
as code owners
martamaja10
approved these changes
Nov 25, 2025
dpiparo
merged commit e227f78
into
root-project:v6-38-00-patches
49 of 50 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a followup of the fix for #20320, #20494, and the corresponding test.