Skip to content

[CI] Don't upload build caches to S3 for Mac15 and Mac26. #20113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CI] Don't upload build caches to S3 for Mac15 and Mac26. #20113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04d003a
[CI] Don't upload build caches to S3 for Mac15 and Mac26.
hageboeck Oct 15, 2025
9e34c62
[CI] Add a "Node state" step for macs to debug the missing cmake prob…
hageboeck Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions .github/workflows/root-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,25 @@ jobs:
${{ (github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' && join( matrix.overrides, ', ' )) || '' }}

steps:
- name: Node state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this step meant to be merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we would like to add some diagnostics for the node to the CI runs.

shell: bash -leo pipefail {0}
run: |
echo $PATH
which cmake || true
find /opt -name cmake -type f || true
find /usr -name cmake -type f || true
cmake --version || true
which c++ || true
c++ --version || true
uname -a || true
sw_vers || true
uptime || true
df || true
echo $SHELL
echo $0
python3 -m site || true
pkgutil --pkg-info=com.apple.pkg.CLTools_Executables || true

- name: Checkout
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -203,8 +222,8 @@ jobs:

- name: Update build cache after push to release branch
shell: bash -leo pipefail {0}
if: github.event_name == 'push'
run: ".github/workflows/root-ci-config/build_root.py
if: ${{ github.event_name == 'push' && !matrix.platform == 'mac15' && !matrix.platform == 'mac26' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to link/relate closer this with the disabling of the use? (I.e. to avoid someone later one trying to renable the use by forgetting to revert this).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to write some info in the environment variables, like so:

<download cached artifacts>
echo ROOT_CI_UPLOAD_ARTIFACTS=1 >> $GITHUB_ENV

This environment variable could be used to trigger the upload step. What do you think @pcanal ?

run: ".github/workflows/root-ci-config/build_root.py
--buildtype RelWithDebInfo
--platform ${{ matrix.platform }}
--incremental false
Expand Down
Loading