-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cling] fallback compiler path when gcc is a soft link to ccache #20099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes root-project#10556 solution proposed by amadio
Test Results 22 files 22 suites 3d 19h 50m 27s ⏱️ Results for commit b46ff63. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@guitargeek is the Roofit test failure in Windows "ok" ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Not really, it's the first time I see it. Thanks for letting me know! But it seem not related to this PR at least. I restarted the tests to check. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Good that all tests are passing now
@ferdymercury Thank you very much for fixing this! |
Fixes #10556
This explores the solution proposed by @amadio (credit goes to him).
I tested that it works fine locally with reproducer #10556 (comment)