-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] use cmake for io/newstl tests, part 4 #19709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 21h 0m 42s ⏱️ For more details on these failures, see this check. Results for commit cd8023a. ♻️ This comment has been updated with latest results. |
Compile macros in advance and use them from srun.C script Avoid usage of rootlogon.C - which automatically involved for all scripts Adjust stlIoTest.ref with actual warnings Remove execute flag for many files Mark as failing readNoLib.C - was fully disabled in Makefile
Windows required correct linking, therefore all depend libs must be linked
…tl test For some reason warning "ROOT does not support variable size array of stl containers" appears for all kind of containers
Seems to be, required on Windows
6de6e81 to
cd8023a
Compare
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 28, 2025
pcanal
reviewed
Oct 28, 2025
pcanal
reviewed
Oct 28, 2025
pcanal
reviewed
Oct 28, 2025
pcanal
reviewed
Oct 28, 2025
pcanal
reviewed
Oct 28, 2025
pcanal
approved these changes
Nov 6, 2025
Member
pcanal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your patience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile macros in advance and use them from srun.C script
Avoid usage of rootlogon.C - which automatically involved for all scripts
Adjust stlIoTest.ref with actual warnings
Remove execute flag for many files
Mark as failing readNoLib.C - was fully disabled in Makefile