[RDF] add HTML display #17106
[RDF] add HTML display #17106
Conversation
silverweed
requested review from
bellenot,
martamaja10,
vepadulano and
dpiparo
as code owners
There was a problem hiding this comment.
Thank you, this is great! I have a couple of minor comments to improve the already very nice changes. As a side thought, these changes also change the behaviour of df.Display in the case of interactive use, from lazy to instant, i.e. now the RDataFrame will run the Display action immediately to print the output table to screen. I believe that's more than valid for interactive use, but we should probably document this. Can you add a line to the release notes (for 6.36 at this point)? Then we should also add some doc about this in the docstrings that can be found in _rdataframe.py
| def repr(klass): | ||
| import ROOT | ||
| opts = ROOT.RDF.RDisplay.RPrintOptions() | ||
| opts.fFormat = ROOT.RDF.RDisplay.EPrintFormat.kHtml | ||
| return klass.AsString(opts) | ||
| klass._repr_html_ = repr |
There was a problem hiding this comment.
Maybe we can add for the non-IPython interactive use case
klass.__repr__ = lambda self: self.AsString()
which will show the markdown table which is friendlier for terminal-based interaction
| return {}; | ||
| } | ||
|
|
||
| std::string RDisplay::AsStringHtml() const |
There was a problem hiding this comment.
Can you also add vertical separators between different columns of the table?
Test Results 18 files 18 suites 4d 7h 22m 57s ⏱️ For more details on these failures, see this check. Results for commit 5605fae. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
rdf_display_html
branch
from
d404135 to
374cc85
Compare
silverweed
force-pushed
the
rdf_display_html
branch
from
bbe0e2e to
d6af15a
Compare
|
I suggest squashing the commits and applying clang-format suggestions if it makes sense before merging |
[RDF] fix test expectation for display
silverweed
force-pushed
the
rdf_display_html
branch
from
d6af15a to
5605fae
Compare
This Pull request:
builds on #17081 and adds the option to print a RDisplay as a HTML table.
Additionally, it uses the HTML display by default as a repr for notebooks.
This is a sample output:
Checklist: