Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF] Forbid calling getVal() with r-value references to norm set #17094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RF] Forbid calling getVal() with r-value references to norm set #17094

wants to merge 1 commit into from
+58 −29

Commits on Nov 27, 2024

  1. [RF] Forbid calling getVal() with r-value references to norm set 

    Calling RooAbsReal::getVal() with r-value references to the
normalization set (i.e. with RooArgSets that are created in place) is a
bad idea, because it breaks RooFits caching logic and potentially
introduces significant overhead.

There was even a dedicated Pythonization to deal with the related memory
problems.

Since to avoid the problems and the need for a workaround in Python,
this commit simply suggests to forbid calling getVal() with r-value
references at runtime by printing a clear exception.
    @guitargeek
    guitargeek committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    d2ed30a View commit details
    Browse the repository at this point in the history