[RF] Deprecate RooDataSet constructors other than universal constructor #17083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it was already pretty close to being formatted according to our clang-tidy style.
The `RooDataSet` constructors to construct a dataset from a part of an existing dataset are deprecated and will be removed in ROOT 6.38. This is to avoid interface duplication. One should use `RooAbsData::reduce()` instead, or to change the weight column, the universal constructor with the `Import()`, `Cut()`, and `WeightVar()` arguments. The tutorials and tests were adjusted accordingly. Also, fix a wrong comment in the `rf403` tutorials: they said that the existing dataset is changed to interpret a different column as the weight, but actually a new dataset was created. The comment is fixed in this commit.
guitargeek
requested review from
couet,
lmoneta,
dpiparo and
pcanal
as code owners
pcanal
reviewed
Nov 27, 2024
| @@ -491,6 +491,14 @@ | |||
| # define _R__DEPRECATED_636(REASON) _R_DEPRECATED_REMOVE_NOW(REASON) | |||
| #endif | |||
|
|
|||
| /* USE AS `R__DEPRECATED(6,38, "Not threadsafe; use TFoo::Bar().")` | |||
There was a problem hiding this comment.
@dpiparo We should consider updating the release process documentation to include adding this macro right after updating the master for the new major release cycle.
Test Results 18 files 18 suites 4d 2h 45m 36s ⏱️ For more details on these failures, see this check. Results for commit 1dedf67. |
lmoneta
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RooDataSetconstructors to construct a dataset from a part of anexisting dataset are deprecated and will be removed in ROOT 6.38. This
is to avoid interface duplication. One should use
RooAbsData::reduce()instead, or to change the weight column, the universal constructor with
the
Import(),Cut(), andWeightVar()arguments.The tutorials and tests were adjusted accordingly.
Also, fix a wrong comment in the
rf403tutorials: they said that theexisting dataset is changed to interpret a different column as the
weight, but actually a new dataset was created. The comment is fixed in
this commit.