Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] build with clingtest flag active if interpreter folder was touched #16917

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ci] build with clingtest flag active if interpreter folder was touched #16917

wants to merge 3 commits into from
+49 −7

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

Fixes #15230

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury marked this pull request as draft November 13, 2024 09:45
@dpiparo dpiparo self-assigned this Nov 15, 2024
@dpiparo dpiparo marked this pull request as ready for review November 30, 2024 11:28
@dpiparo dpiparo closed this Nov 30, 2024
@dpiparo dpiparo reopened this Nov 30, 2024
dpiparo
dpiparo approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a great attempt to introduce a useful new feature. It seems some information is still needed before starting to test it thoroughly.

.github/workflows/root-ci.yml Outdated Show resolved Hide resolved
.github/workflows/root-ci.yml Outdated Show resolved Hide resolved
@dpiparo
Copy link
Member

dpiparo commented Nov 30, 2024

@vgvassilev

@vgvassilev
Copy link
Member

These changes are too advanced for me. Maybe @mcbarton could take a look...

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2024 •
edited
Loading

Test Results

    19 files      19 suites   4d 2h 55m 53s ⏱️
 2 726 tests  2 701 ✅ 1 💤 24 ❌
49 146 runs  49 117 ✅ 0 💤 29 ❌

For more details on these failures, see this check.

Results for commit 6d5e3a8.

♻️ This comment has been updated with latest results.

@ferdymercury
Copy link
Contributor Author

ferdymercury commented Nov 30, 2024 •
edited
Loading

It's working now.

Should we also:

  • set LLVM_BUILD_TYPE=Debug ?
  • add more platforms ? Right now: both windows, one mac, one ubuntu, one linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbarton mcbarton mcbarton left review comments

@vgvassilev vgvassilev Awaiting requested review from vgvassilev

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@hahnjo hahnjo Awaiting requested review from hahnjo

Assignees

@dpiparo dpiparo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] clingtest=ON when cling touched
4 participants
@ferdymercury @dpiparo @vgvassilev @mcbarton