[ORC] Preserve order of constructors with same priority [v6.30] #15858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructors with the same priority should keep their relative order
that was specified. This is important for clang-repl with many const
variables after commit 05137ecfca ("[clang-repl] Emit const variables
only once").
---
Fixes root-project#15511
(version of commit a60f353 for
LLVM 13 in v6-30-00-patches)
Test Results 11 files 11 suites 2d 5h 33m 7s ⏱️ Results for commit 130a47b. |
|
I tested this and I can confirm I do not see the segfault anymore. Can you have a 6.30 tag, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors with the same priority should keep their relative order that was specified. This is important for
clang-replwith manyconstvariables after commit llvm/llvm-project@05137ec ("[clang-repl] Emit const variables only once").Fixes #15511
(version of commit a60f353 for LLVM 13 in
v6-30-00-patches, backport of #15854)