[tmva][sofie] Fix when specifying input batch size in Model #15819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When input shape is parametric, give possibility to fix the batch size if provided by user in RModel::Generate
lmoneta
force-pushed
the
fix_sofie_input_bs
branch
from
bffabe6 to
d99d652
Compare
|
Test and linked issue? |
Test Results 12 files 12 suites 2d 19h 16m 52s ⏱️ For more details on these failures, see this check. Results for commit a7e4c2b. ♻️ This comment has been updated with latest results. |
|
This is needed to fix root bench: |
Fix for setting t he batch size when parsing a Keras model where the input batch size is not defined Add extra optional parameter in the Parse function to specify the batch size
…enerateModel The GenerateModel function called for the GNN classes was having a default =1 for the batch size used when generating the update models. We should use -1 to not force any specific batch size and use directly the given input shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request fixes the use case when the batch size is specified in RModel::Generate and the input model does not have a given batch size, but a parametric one