[cling-cpt] Removed 2 globals and implemented them with parameter passing [skip-ci] #11058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vgvassilev
reviewed
Jul 28, 2022
| @@ -1869,7 +1871,7 @@ def custom_input(prompt, always_yes=False): | |||
| workdir = os.path.abspath(os.path.expanduser(args['with_workdir'])) | |||
| srcdir = os.path.join(workdir, 'cling-src') | |||
| CLING_SRC_DIR = os.path.join(srcdir, 'tools', 'cling') | |||
| CPT_SRC_DIR = os.path.join(CLING_SRC_DIR, 'tools', 'packaging') | |||
| # CPT_SRC_DIR = os.path.join(CLING_SRC_DIR, 'tools', 'packaging') | |||
There was a problem hiding this comment.
Can you remove the commented code? This PR seems good to go.
There was a problem hiding this comment.
Hi @vgvassilev just removed the commented code
saisoma123
force-pushed
the
moreGlobalVarFixes
branch
from
debd1ff
to
ea5ac62
Compare
vgvassilev
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Reduces global variable mutation
Changes or fixes: Removed the CPT_SRC_DIR and REVISION global variables and implemented them in the functional parameter passing style.
Checklist:
This PR fixes #406 mentioned in meta issue list (root-project/cling#406)