[cling-cpt] Made a new build option for last-stable and current-dev [skip-ci] #11019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can you provide a rationale of the new options and in which situations they are useful? |
|
@vgvassilev just added a rationale to the first commit message |
saisoma123
force-pushed
the
buildOpt
branch
2 times, most recently
from
ad79f3b
to
da27411
Compare
vgvassilev
reviewed
Aug 3, 2022
| LLVM_GIT_URL = args['with_llvm_url'] | ||
| else: | ||
| LLVM_GIT_URL = "http://root.cern.ch/git/llvm.git" | ||
|
|
||
| if args['with_binary_llvm'] and args['with_llvm_tar']: | ||
|
|
| travis_fold_start("git-clone") | ||
| current_cond = args['current_dev'] if args['current_dev'] else args['current_dev_build'] |
There was a problem hiding this comment.
Can we use a more meaningful name here? Is this meant to say current_branch?
| cleanup() | ||
|
|
||
| elif args['current_dev'] == 'deb' or (args['current_dev'] == 'pkg' and DIST == 'Ubuntu'): | ||
| elif current_cond == 'deb' or (current_cond == 'pkg' and DIST == 'Ubuntu'): |
There was a problem hiding this comment.
Likewise. Is this meant to say current_packaging_mode?
There was a problem hiding this comment.
@vgvassilev Yeah just fixed everything thanks for letting me know
I added this option because it was listed as an improvement that could be made to the CPT on the meta issue list. These options are nice to have because sometimes the user might just want to build Cling and not package it, for fast testing and usage.
vgvassilev
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Allows for users to have the option of just building the CPT not packaging it.
Changes or fixes: Added a current-dev-build and last-stable-build option in the argument parser, and added additional if statements if it is the normal current-dev or last-stable option, so that there is also packaging like normal.
Checklist:
This PR fixes #406 mentioned in (root-project/cling#406)