[cling-cpt] More splitting lines for getting rid of E501 error cont. [skip-ci] #11011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jalopezg-git
suggested changes
Jul 21, 2022
Comment on lines
100
to
101
| msg = 'cling (' + platform.machine() + ')' | ||
| + formatdate(time.time(), tzinfo()) |
There was a problem hiding this comment.
I doubt that breaking the line there works (syntax error in line 101). Perhaps a missing \? (same below)
There was a problem hiding this comment.
Yeah you're right I'll fix that thank you
|
Can you merge this PR and #11010? |
|
@vgvassilev Yeah just merged and rebased |
vgvassilev
approved these changes
Aug 13, 2022
jalopezg-git
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Makes the code more flake8 compliant.
Changes or fixes: Split lines that were longer than 79 characters.
Checklist:
This PR fixes issue #406 mentioned in (root-project/cling#406)