-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cling-cpt] Fixed argument nomenclature [skip-ci] #10936
Conversation
Can one of the admins verify this patch? |
If we make this rename we need to make sure we rename all its uses in places such as |
Hi @vgvassilev, where are the places specifically I have to add the renames? |
|
@vgvassilev just added the renames to the files you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you rebase the PR and then I can merge it.
Hi @vgvassilev, just rebased the PR |
@saisoma123, I have squashed the commits. In future we should do these changes in a single commit to have a clearer history. |
@vgvassilev, will keep that in mind for the future, thanks. |
This Pull request: Rewrote parser arguments for better nomenclature.
Changes or fixes: Multiple arguments now have with prefix
Checklist:
This PR fixes issue in list #406 (root-project/cling#406)