Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cling-cpt] Fixed argument nomenclature [skip-ci] #10936

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

saisoma123
Copy link
Contributor

This Pull request: Rewrote parser arguments for better nomenclature.

Changes or fixes: Multiple arguments now have with prefix

Checklist:

  • tested changes locally
  • [NA] updated the docs (if necessary)

This PR fixes issue in list #406 (root-project/cling#406)

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@vgvassilev
Copy link
Member

If we make this rename we need to make sure we rename all its uses in places such as .github/workflows/ci.yml.

@saisoma123
Copy link
Contributor Author

Hi @vgvassilev, where are the places specifically I have to add the renames?

@vgvassilev
Copy link
Member

Hi @vgvassilev, where are the places specifically I have to add the renames?

interpreter/cling/.github/workflows/ci.yml:          python3 cpt.py -y --check-requirements --current-dev=tar --with-cmake-flags="$CLING_BUILD_FLAGS" --with-cling-url=https://github.com/$REPO --cling-branch=${{ github.head_ref }} --with-binary-llvm --with-llvm-tar
interpreter/cling/.github/workflows/ci.yml:          python3 cpt.py -y --check-requirements --current-dev=tar --with-cmake-flags="$CLING_BUILD_FLAGS" --with-cling-url=https://github.com/$REPO --cling-branch=${{ github.head_ref }} --with-binary-llvm
interpreter/cling/.travis.yml:      --with-binary-llvm \
interpreter/cling/.travis.yml:      --with-binary-llvm \

@saisoma123
Copy link
Contributor Author

@vgvassilev just added the renames to the files you mentioned.

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you rebase the PR and then I can merge it.

@saisoma123
Copy link
Contributor Author

Hi @vgvassilev, just rebased the PR

@vgvassilev vgvassilev merged commit 7c8cce5 into root-project:master Jul 15, 2022
@vgvassilev
Copy link
Member

@saisoma123, I have squashed the commits. In future we should do these changes in a single commit to have a clearer history.

@saisoma123
Copy link
Contributor Author

@vgvassilev, will keep that in mind for the future, thanks.

vepadulano pushed a commit to vepadulano/root that referenced this pull request Jul 20, 2022
j-mathe pushed a commit to j-mathe/root that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants