[cling-cpt] Formatted code to be flake8 compliant [skip-ci] #10862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I am worried about this change as it is very big. Did that formatting come from some automatic linter? |
|
Sorry I first used yapf to format, then the remaining errors I fixed myself |
Axel-Naumann
requested review from
vgvassilev
and removed request for
Axel-Naumann
|
I am not sure I am qualified to review these changes. I prefer to have smaller and more understandable diffs. |
|
Hi @vgvassilev, I think I could make it easier for you to review if I make smaller pull requests and each one corresponds to a certain flake8 error code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Makes the code flake8 compliant
Changes or fixes: Reformatted the entire file using yapf and got rid of remaining flake8 errors manually.
Checklist:
This PR fixes the issue mentioned #406 in (root-project/cling#406)